Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of nested if conditions #2372

Merged
merged 1 commit into from
Oct 8, 2022
Merged

get rid of nested if conditions #2372

merged 1 commit into from
Oct 8, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Oct 4, 2022

Easier to read with lambdas.

Signed-off-by: Rosen Penev [email protected]

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #2372 (7f913b4) into main (a2cb06a) will increase coverage by 0.02%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #2372      +/-   ##
==========================================
+ Coverage   64.14%   64.16%   +0.02%     
==========================================
  Files         119      119              
  Lines       21071    21090      +19     
  Branches    10394    10401       +7     
==========================================
+ Hits        13515    13533      +18     
- Misses       5400     5401       +1     
  Partials     2156     2156              
Impacted Files Coverage Δ
src/image.cpp 70.45% <91.66%> (+0.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2022

This pull request fixes 1 alert when merging b09a91a into a2cb06a - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

src/image.cpp Outdated Show resolved Hide resolved
src/image.cpp Outdated Show resolved Hide resolved
Easier to read with lambdas.

Signed-off-by: Rosen Penev <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2022

This pull request fixes 1 alert when merging 7f913b4 into a2cb06a - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

@neheb neheb merged commit fd7566f into Exiv2:main Oct 8, 2022
@neheb neheb deleted the 1 branch October 8, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants